Added obsolete note to SmtpClient type summary #2483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillWagner
approved these changes
May 23, 2019
There was a problem hiding this comment.
This LGTM @rpetrusha
I had one question, but you can 
when ready.
| @@ -35,7 +35,7 @@ | |||
| </Attribute> | |||
| </Attributes> | |||
| <Docs> | |||
| <summary>Allows applications to send email by using the Simple Mail Transfer Protocol (SMTP).</summary> | |||
| <summary>Allows applications to send email by using the Simple Mail Transfer Protocol (SMTP). The <c>SmtpClient</c> type is now obsolete.</summary> | |||
There was a problem hiding this comment.
Is there are recommended alternative? That's going to be an obvious question for readers when they see this.
There was a problem hiding this comment.
The recommended alternatives are listed in the obsolete message, which appears in the syntax section, @BillWagner. There is no .NET base class library alternative.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added obsolete note to SmtpClient type summary
Related to #2420